Downloads Documentation Community
Contribute
Contribute Demo






Show Sidebar
Login | Register


Ticket #907 (closed task: fixed)

Opened 2 years ago

Last modified 1 year ago

Demo data has concepts without concept names

Reported by: kevjay Assigned to: somebody
Priority: trivial Milestone: (Completed) OpenMRS 1.4
Component: Concept Dictionary Keywords:
Cc: bmamlin, tdugan Introductory Ticket: 0
Code Review Status:

Description

The concept IDs 1290 and 1291 do not have associated concept names in the demo db. This causes problems when trying to use the Logic Service. For instance, the test at http://svn.openmrs.org/openmrs-modules/logicws/test/org/openmrs/module/logicws/test/LogicWsTest.java that returns the available tokens will fail with "No concept name found for default locale for concept id 1291". This error was resolved by manually inserting concept names via SQL for the concept IDs 1290 and 1291.

Change History

07/14/08 23:42:09 changed by bwolfe

  • priority changed from major to trivial.
  • milestone set to OpenMRS 1.4.

07/25/08 23:06:22 changed by jmiranda

  • cc set to bmamlin, tdugan.

Tammy, Burke

What's the proper behavior here? Should we log an error and ignore concepts without a name? I've started going through the code, adding checks for whether the Concept.getName() method returns null. Before I commit, I would like to hear what you think.

08/12/08 12:04:48 changed by bwolfe

I'd vote you log and error and return null. Put something in the javadoc saying that the method might return null and that the end user should do something about it.

08/12/08 16:32:28 changed by bmamlin

This error is an artifact from the hack that is currently registering all concepts as tokens when the first request is made to the logic service. Ideally, this error would have already been encountered when something outside of the logic service registered all observation concepts during startup and/or as the logic service was restoring persisted tokens/rules during startup.

We could:

  1. Fix the demo dataset.
  2. Fix the init() hack in RuleFactory (I think that's where it is) so that nameless concepts are not registered as tokens.

In the future, this error could not occur in the logic service, since it will not be registering tokens itself.

08/12/08 21:47:58 changed by bwolfe

Concepts 1290 and 1291 removed in [5266]

01/13/09 18:17:32 changed by bwolfe

  • status changed from new to closed.
  • intro_ticket changed.
  • resolution set to fixed.
  • review_status changed.