Downloads Documentation Community Contribute Demo






Show Sidebar
Login | Register

Ticket #819 (closed task: fixed)

Opened 1 year ago

Last modified 5 months ago

HibernateAdministrationDAO.executeSQL() logging unwanted stack trace

Reported by: upul Assigned to: bwolfe
Priority: major Milestone: OpenMRS 1.5
Component: OpenMRS Code Base Keywords:
Cc: Introductory Ticket: 0
Code Review Status:

Description

HibernateAdministrationDAO.java:466

catch (SQLException e) {

log.error("Error while running sql: " + sql, e); <<<------ throw new DAOException("Error while running sql: " + sql + " . Message: " + e.getMessage(), e);

}

log.error() line could be removed. So the caller can log if wanted. In the current implementation of the tribe module, this method is used to check the existence of the tribe column in the patient. (An exception is thrown when the column is not found which signals that the openmrs code is a new version.)

Change History

01/29/09 13:59:24 changed by bwolfe

  • status changed from new to closed.
  • intro_ticket changed.
  • resolution set to fixed.
  • review_status changed.
  • milestone set to OpenMRS 1.5.

This was lowered to a log.debug statement in [6505]