Downloads Documentation Community Contribute Demo






Show Sidebar
Login | Register

Ticket #819 (new task)

Opened 2 months ago

HibernateAdministrationDAO.executeSQL() logging unwanted stack trace

Reported by: upul Assigned to: bwolfe
Priority: major Milestone:
Component: OpenMRS Code Base Keywords:
Cc:

Description

HibernateAdministrationDAO.java:466

catch (SQLException e) {

log.error("Error while running sql: " + sql, e); <<<------ throw new DAOException("Error while running sql: " + sql + " . Message: " + e.getMessage(), e);

}

log.error() line could be removed. So the caller can log if wanted. In the current implementation of the tribe module, this method is used to check the existence of the tribe column in the patient. (An exception is thrown when the column is not found which signals that the openmrs code is a new version.)