Downloads Documentation Community
Contribute
Contribute Demo






Show Sidebar
Login | Register


Ticket #804 (closed enhancement: fixed)

Opened 1 year ago

Last modified 8 months ago

Person Attribute Edit Permission

Reported by: bwolfe Assigned to: upul
Priority: trivial Milestone: OpenMRS 1.5
Component: OpenMRS Code Base Keywords:
Cc: jarbaugh, upul, jmiranda, bmamlin Introductory Ticket: 0
Code Review Status:

Description

The #624 Edit Tribe Permission branch was a quick fix. Now that the tribe object is going away and turning into a Person Attribute #652 (via a tribe module), edit permissions need to be added to Person Attributes.

A new attribute and column on PersonAttribute should be added named "Edit Privilege" (or something similar). If empty or null, the person attribute is editable by anyone who can edit persons. If non-null, the current user must have that privilege in order to edit it...otherwise they can only view it.

Attachments

openmrs-804.patch (10.6 kB) - added by bwolfe on 09/26/08 15:13:46.
attribute-priv-and-tribe.patch (96.5 kB) - added by bwolfe on 10/21/08 20:09:11.
Combined PersonAttributeType.editPrivilege and removal of Tribe patch

Change History

06/17/08 19:21:14 changed by upul

  • owner changed from somebody to bwolfe.

06/27/08 13:07:18 changed by bwolfe

Looks good.

There are only two minor additions:

The update-to-latest script will need that sql change. The edit_privilege column will also need to be foreign keyed to the privilege table.

When editing a person attribute type, the user should see a drop down instead of a plain text box to select the privilege.

Pending these changes and a review from the wider community about the schema change, this will be applied before the 1.4 release.

09/26/08 15:13:46 changed by bwolfe

  • attachment openmrs-804.patch added.

09/26/08 15:14:29 changed by bwolfe

  • intro_ticket changed.

Updated patch to work with latest trunk

10/21/08 20:09:11 changed by bwolfe

  • attachment attribute-priv-and-tribe.patch added.

Combined PersonAttributeType.editPrivilege and removal of Tribe patch

10/21/08 20:16:28 changed by bwolfe

  • owner changed from bwolfe to upul.

Added patch to work with latest trunk. Patch also contains some fixes from the code review session: http://openmrs.org/wiki/2008-10-21_Code_Review

Patch is combined with the one in ticket #652.

Reassigning to Upul as he did most of the work on this one.

11/11/08 22:26:06 changed by bwolfe

  • status changed from new to closed.
  • resolution set to fixed.
  • milestone changed from OpenMRS 1.4 to OpenMRS 1.5.

Committed to trunk in [5974]