Downloads Documentation Community
Contribute
Contribute Demo






Show Sidebar
Login | Register


Ticket #776 (closed defect: fixed)

Opened 6 months ago

Last modified 6 months ago

Cannot edit users

Reported by: djazayeri Assigned to: bwolfe
Priority: critical Milestone: OpenMRS 1.3
Component: OpenMRS Code Base Keywords:
Cc: catullus, bwolfe, djazayeri Introductory Ticket:

Description

There's a bug in UserFormController.onSubmit() that prevents you from editing a user. I believe this was introduced in [4087] when HibernateUserDAO had a merge() switched to a saveOrUpdate().

Patch is attached for whenever you're done merging. Make sure this gets in before RC2.

We need to fix this ASAP in Rwanda, so we'll apply this directly to the sync branch.

Attachments

editUser.patch (1.0 kB) - added by djazayeri on 05/24/08 00:43:23.
usercreationfix.patch (0.9 kB) - added by catullus on 06/02/08 15:25:32.

Change History

05/24/08 00:43:23 changed by djazayeri

  • attachment editUser.patch added.

05/24/08 11:51:34 changed by djazayeri

More about the problem documented here http://openmrs.org/wiki/Troubleshooting_Hibernate

05/25/08 15:06:41 changed by djazayeri

  • status changed from new to closed.
  • resolution set to fixed.

Fixed in [4362]

06/02/08 15:25:32 changed by catullus

  • attachment usercreationfix.patch added.

06/02/08 15:27:12 changed by catullus

  • cc changed from catullus to catullus, bwolfe, djazayeri.

Added patch to fix bug introduced by darius's patch. These two patches need to be backported to trunk in order.

06/02/08 15:38:45 changed by bwolfe

Darius had already applied this fix and I had already found/fixed the NPE problem. see [4373]

Current source code: source:openmrs/trunk/src/web/org/openmrs/web/controller/user/UserFormController.java