Downloads Documentation Community
Contribute
Contribute Demo






Show Sidebar
Login | Register


Ticket #652 (closed task: fixed)

Opened 2 years ago

Last modified 5 months ago

Move tribe to person attribute

Reported by: bmamlin Assigned to: upul
Priority: minor Milestone: OpenMRS 1.5
Component: OpenMRS Code Base Keywords:
Cc: bwolfe, mseaton, jarbaugh Introductory Ticket: 0
Code Review Status:

Description

When OpenMRS started, tribe was an attribute of the patient table. Over time, we developed the person_attribute table to hold implementation-specific attributes of people. Since not all implementation need/want tribe as part of the system, person_atttribute is a better place for it. One option would be to migrate tribe to person attributes over a couple OpenMRS updates (deprecating it in one and removing in another). Then a tribe module could be created to add the tribe functionality for those implementations who want it.

See also #624

Attachments

openmrs-652.patch (90.1 kB) - added by bwolfe on 09/26/08 13:47:52.
attribute-priv-and-tribe.patch (96.5 kB) - added by bwolfe on 10/21/08 20:17:23.
Combined patch with Edit Person Attribute permission and Tribe removal

Change History

05/27/08 17:04:17 changed by bwolfe

  • owner changed from somebody to upul.
  • milestone changed from OpenMRS 1.3 to OpenMRS 1.4.

06/06/08 17:08:58 changed by bwolfe

  • cc changed from bwolfe to bwolfe, mseaton, jarbaugh.

Awesome, thanks for this Upul. It looks like you've found everything.

My only suggestions are for the patch are:

  1. Leave the Manage Tribes page there with a note on it saying that you should download the Tribe module and install it now.

actually, thats all for the patch.

The module needs to extend the org.openmrs.patientDashboard.Header extensionPoint and add the tribe back to the patient dashboard.

#804 will need to be fixed soon after this change for James Arbaugh's needs and the Edit Tribe Permission hack that was put in.

06/27/08 13:17:59 changed by bwolfe

I see in [4599] you added a note in the old location. However, I was meaning to leave a note in core code alluding to the fact that there is a module that they should use now. I think this is necessary because some people will download 1.4, see no tribes page and freak out. A text there that says "go here to download a new module, all your data will be imported..." will calm them down.

In 1.5 we can remove that link and text and just assume people will go and download the module.

08/14/08 13:57:56 changed by bwolfe

The mysql diff update file needs to get rid of the old permissions: 

delete from role_privilege where privilege like '%Tribes';

otherwise, the user pages and manage role pages don't work. :-)

09/26/08 13:45:38 changed by bwolfe

  • intro_ticket changed.

On second look, the privilege doesn't really need to be deleted as long as the Manage Tribes relationship between privilege isn't deleted.

I've attached an updated patch against the latest trunk and I modified the message on the old tribe that points users at the new tribe module.

09/26/08 13:47:52 changed by bwolfe

  • attachment openmrs-652.patch added.

10/21/08 20:17:23 changed by bwolfe

  • attachment attribute-priv-and-tribe.patch added.

Combined patch with Edit Person Attribute permission and Tribe removal

10/21/08 20:17:45 changed by bwolfe

Added patch to work with latest trunk. Patch also contains some fixes from the code review session: http://openmrs.org/wiki/2008-10-21_Code_Review

Patch is combined with the one in ticket #804.

11/11/08 22:26:27 changed by bwolfe

  • status changed from new to closed.
  • resolution set to fixed.
  • milestone changed from OpenMRS 1.4 to OpenMRS 1.5.

Committed to trunk in [5974]

11/26/08 20:08:10 changed by bwolfe

Fixed an issue with the Field object on forms pointing to Patient.Tribe still. See [6130]