Downloads Documentation Community
Contribute
Contribute Demo






Show Sidebar
Login | Register


Ticket #2079 (closed task: fixed)

Opened 1 month ago

Last modified 3 days ago

Add simple Logic Module admin page with ability to register default logic rules

Reported by: slorenz Assigned to: slorenz
Priority: major Milestone: OpenMRS 1.6
Component: Logic Service Keywords:
Cc: djazayeri, nribeka, bwolfe, syhaas Introductory Ticket: 1
Code Review Status: Needs Review

Description

The logic module would benefit from a new admin page which would allow users to manually load default logic rules from concepts using the LogicUtil.registerDefaultRules() method. This method can take several minutes to complete so this should be run in a separate thread with appropriate feedback (e.g. indicating that the process is running and not hung) provided to the user. As additional reference, please see this thread http://n2.nabble.com/OpenMRS-1-6-Beta-released-td4484824.html#a4484824.

Attachments

patch2079.txt (14.7 kB) - added by slorenz on 02/12/10 15:04:22.
isAnswerOnly.patch (3.0 kB) - added by djazayeri on 03/08/10 17:13:43.
patch for core
flushSession.patch (2.2 kB) - added by djazayeri on 03/08/10 17:19:35.
logicUtil-dj-edits.patch (8.4 kB) - added by djazayeri on 03/08/10 18:04:35.

Change History

02/11/10 15:34:33 changed by djazayeri

This is not strictly required for 1.6 release. It could go in a followup release of the logic module. (But it would be preferable to have it in 1.6.)

02/11/10 17:03:29 changed by slorenz

  • status changed from new to assigned.

I believe this is nearly complete. I am waiting to resolve an issue with Ticket 2052 http://dev.openmrs.org/ticket/2052 to make sure I am calling the LogicUtil.registerDefaultRules() method the right way.

02/12/10 15:04:03 changed by slorenz

  • review_status set to Needs Review.

The patch is ready for review.

02/12/10 15:04:22 changed by slorenz

  • attachment patch2079.txt added.

02/18/10 22:18:04 changed by bwolfe

  • cc changed from djazayeri, nribeka, bwolfe to djazayeri, nribeka, bwolfe, syhaas.

This patch looks good. We'll apply this as the same time as #2052 and release logic 0.3.

03/08/10 17:13:22 changed by djazayeri

I want to make a couple changes to this:

  • I'm going to add a json.jar to core, and have this module call that, instead of needing to provide its own json
  • Explicitly show the GP that controls what datatypes get loaded (via the GP portlet?)
  • Change registerDefaultTokens() to skip N/A concepts. (This requires a patch to core, which I'm attaching here.)

03/08/10 17:13:43 changed by djazayeri

  • attachment isAnswerOnly.patch added.

patch for core

03/08/10 17:19:35 changed by djazayeri

  • attachment flushSession.patch added.

03/08/10 17:19:55 changed by djazayeri

Also, I want to have registerDefaultRules periodically flush its changes to the database, to avoid the hibernate session getting full, and things slowing down.

That patch is also attached.

03/08/10 18:04:16 changed by djazayeri

Finally, here are my edits to slorenz's patch

03/08/10 18:04:35 changed by djazayeri

  • attachment logicUtil-dj-edits.patch added.

03/10/10 02:05:01 changed by djazayeri

  • status changed from assigned to closed.
  • resolution set to fixed.

Fixed in [12368] which will be logic module 0.4