Downloads Documentation Community
Contribute
Contribute Demo






Show Sidebar
Login | Register


Ticket #1906 (closed task: fixed)

Opened 5 months ago

Last modified 1 month ago

XForms module does not load in 1.5.x

Reported by: djazayeri Assigned to: sagarys
Priority: blocker Milestone: OpenMRS 1.6
Component: XForms Module Keywords:
Cc: hablutzel1, daniel Introductory Ticket: 0
Code Review Status: Needs Review

Description

In the current 1.5.x the scheduler_task_config table has had a uuid column added.

The xforms module attempts to create scheduled tasks via sql, but it fails because uuid is required.

-Darius

Attachments

1906_XForm_UUID.patch (21.0 kB) - added by sagarys on 01/14/10 06:53:07.
Patch file which edits the scripts for 'scheduler_task_config' table to accomodate the column UUID

Change History

12/31/09 15:33:07 changed by bwolfe

  • cc set to hablutzel1.

Marking #1994 as a duplicate of this ticket.

Jaime, can you attach a .patch file to this ticket for Daniel to review/apply?

01/14/10 06:31:13 changed by sagarys

  • owner changed from dkayiwa to sagarys.
  • status changed from new to assigned.

01/14/10 06:53:07 changed by sagarys

  • attachment 1906_XForm_UUID.patch added.

Patch file which edits the scripts for 'scheduler_task_config' table to accomodate the column UUID

01/14/10 19:25:13 changed by bwolfe

Daniel, can you review/apply this patch?

01/15/10 20:12:01 changed by bwolfe

  • cc changed from hablutzel1 to hablutzel1, daniel.
  • priority changed from major to blocker.
  • milestone set to OpenMRS 1.6.

The xforms module will not load in openmrs 1.5 or 1.6 without this patch.

01/18/10 12:47:00 changed by dkayiwa

This patch makes the module throw exceptions for versions of openmrs lower than 1.6 which do not have the uuid column.

01/18/10 17:54:57 changed by djazayeri

Hi Daniel,

Just FYI, for the HTML Form Entry module I actually needed to have 1.4.x, 1.5.x, and 1.6.x branches, to get things to work.

01/18/10 18:00:44 changed by dkayiwa

Thanks Darius for sharing that what you have done with the HTML Form Entry module.

How do you compare that approach with just doing only the problematic sql statements updates in the Activator, where i would know whether we have the uuid field or not?

01/18/10 19:03:54 changed by djazayeri

If you're just talking about creating scheduler tasks, it makes sense to do that in the activator, yes.

(Because when they upgrade from 1.4 to 1.5 that should automatically upgrade scheduler_task_config without you having to do anything.)

01/22/10 14:50:53 changed by bwolfe

You can't fix this in the activator because the module doesn't even load in 1.5. The sqldiff is run before the activator and the sqldiff is where the problem is. The uuid column is a "non-null unique" column and must be filled in when creating those rows.

Doing sql updates in the activator is not recommended anyway. The solution is to have a 1.4.x-compatible branch off of your current code in your module. Then in trunk its 1.5+ compatible, so you set the openmrs version in your config.xml to 1.5.0.

02/02/10 16:50:48 changed by bwolfe

  • review_status set to Needs Review.

Marking as Needs Review so Daniel can weigh in on if he wants to create the 1.5.x-compatible branch or not.

02/02/10 17:39:54 changed by daniel

I removed the automatic creation of scheduled tasks. This has almost no impact on module users because i submit the forms immediately to the database without having to queue them first (like i used to do before) and hence not requiring a scheduled task to remove them from the queue.

02/02/10 18:06:59 changed by bwolfe

  • status changed from assigned to closed.
  • resolution set to fixed.

Great! Marking this as fixed in the 3.8.0 release of the xforms module.