Downloads Documentation Community
Contribute
Contribute Demo






Show Sidebar
Login | Register


Ticket #1533 (closed defect: fixed)

Opened 10 months ago

Last modified 8 months ago

PatientService.getPatientIdentifiers() returns voided patients

Reported by: jmiranda Assigned to: nribeka
Priority: critical Milestone: OpenMRS 1.5
Component: OpenMRS Code Base Keywords:
Cc: djazayeri Introductory Ticket: 0
Code Review Status:

Description

This is according to Darius (via cell phone). We need to create an @should and test case to see if this the case.

Attachments

patient-identifiers-voided.diff (3.2 kB) - added by nribeka on 07/02/09 20:39:34.
patch to prevent voided patients's identifiers get returned

Change History

07/01/09 13:51:23 changed by nribeka

Justin,

We want to avoid the patient identifiers that has been voided right? Patient identifiers, not the patient?

07/01/09 20:13:28 changed by nribeka

  • owner changed from somebody to nribeka.

07/01/09 20:25:52 changed by jmiranda

This was a bug reported by Darius, so I'll let him have the last word.

I think he meant that PatientService.getPatientIdentifiers() should return PatientIdentifiers where PatientIdentifier.getVoided() == false AND PatientIdentifier.getPatient().getVoided() == false. In other words, if a patient has been voided, we don't want to see their PatientIdentifiers.

07/01/09 20:34:43 changed by djazayeri

Yes, that's what I meant: Calls to getPatientIdentifiers() should not return identifiers that belong to voided patients.

I forget where this was causing a bug. And I forget whether the methods I was talking about was supposed to have parameters or not.

-Darius

07/02/09 20:39:34 changed by nribeka

  • attachment patient-identifiers-voided.diff added.

patch to prevent voided patients's identifiers get returned

07/02/09 20:40:00 changed by nribeka

patch added for review.

07/06/09 16:55:41 changed by bwolfe

  • status changed from new to closed.
  • resolution set to fixed.

Fixed in trunk in [8916] and in 1.5.x in [8917]