Downloads Documentation Community
Contribute
Contribute Demo






Show Sidebar
Login | Register


Ticket #1166 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

Cohort Column broken in data exports

Reported by: djazayeri Assigned to: djazayeri
Priority: major Milestone: (Completed) OpenMRS 1.4
Component: OpenMRS Code Base Keywords: data export
Cc: pctjose@GMAIL.COM, jmiranda, bwolfe Introductory Ticket: 0
Code Review Status: Needs Review

Description

Any cohort columns (cohort, saved search, or saved filter) always shows up blank in data exports.

I haven't verified whether this bug exists in 1.3, but if so a fix should be backported.

Attachments

1166.patch (3.9 kB) - added by djazayeri on 12/12/08 18:05:37.

Change History

12/12/08 18:05:37 changed by djazayeri

  • attachment 1166.patch added.

12/12/08 18:07:49 changed by djazayeri

  • cc changed from pctjose@GMAIL.COM to pctjose@GMAIL.COM, jmiranda, bwolfe.
  • status changed from new to assigned.
  • review_status set to Needs Review.

Unit test format is not exactly right, since I don't have the generate test cases plugin working.

This fixes it back up to how it worked before we introduced reporting evaluation contexts. The data export should probably create one of those and keept it around for the duration of a single data export generation. But that's left as a TODO.

Ben, Justin, quick code review on this?

12/15/08 17:35:21 changed by djazayeri

Bug also exists in 1.3.x so needs to be backported there too.

12/15/08 19:08:49 changed by bwolfe

Your DataExportFunctions and a slightly modified DataExportTest have been committed to trunk in [6288]

A backport to the 1.4.x and 1.3.x branches is still needed.

12/15/08 20:13:30 changed by djazayeri

  • status changed from assigned to closed.
  • resolution set to fixed.

Backported to 1.4.x in [6289]. Backported to 1.3.x in [6290].